Skip to content

Commit

Permalink
Fixed registration bug where height was overwritten by baseheight
Browse files Browse the repository at this point in the history
  • Loading branch information
nfearnley committed Nov 11, 2023
1 parent 0e18fe6 commit c95d14b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions sizebot/cogs/setbase.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ async def setbaseheight(self, ctx, *, newbaseheight: SV):

# Convenience for initial registration
if "setbaseheight" in userdata.registration_steps_remaining:
userdata.height = newbaseheight
if not (SV.parse("4ft") < newbaseheight < SV.parse("8ft")):
await ctx.send(f"{emojis.warning} **WARNING:** Your base height should probably be something more human-scale. This makes comparison math work out much nicer. If this was intended, you can ignore this warning, but it is ***highly recommended*** that you have a base height similar to the size of a normal human being.")

Expand Down Expand Up @@ -87,7 +86,6 @@ async def setbase(self, ctx, arg1: typing.Union[SV, WV], arg2: typing.Union[SV,
completed_registration = False
if newbaseheight is not None:
if "setbaseheight" in userdata.registration_steps_remaining:
userdata.height = newbaseheight
# TODO: Actually have a confirm message here.
if not (SV.parse("4ft") <= newbaseheight < SV.parse("8ft")):
await ctx.send(f"{emojis.warning} **WARNING:** Your base height should probably be something more human-scale. This makes comparison math work out much nicer. If this was intended, you can ignore this warning, but it is ***highly recommended*** that you have a base height similar to the size of a normal human being.")
Expand Down

0 comments on commit c95d14b

Please sign in to comment.