Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rainbow component #25

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix rainbow component #25

merged 2 commits into from
Nov 22, 2024

Conversation

Teero888
Copy link

This fixes the several divisions by 0, the broken pulsing option and the unnecessary loop over all players even if rainbow isn't enabled + overall style.

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

@BlaiZephyr
Copy link

Teero fixes style

Has ci fail because of style

@Teero888
Copy link
Author

Teero fixes style

Has ci fail because of style

my changes don't make the ci fail xd
look at the details

@BlaiZephyr
Copy link

Teero fixes style
Has ci fail because of style

my changes don't make the ci fail xd look at the details

I would never, my comments are based off pure subjective hatred against ci's

@sjrc6 sjrc6 merged commit db27178 into sjrc6:master Nov 22, 2024
12 of 14 checks passed
@sjrc6
Copy link
Owner

sjrc6 commented Nov 22, 2024

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants