[enhancement] 添加 GitHub 问题模板 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ce Gao <[email protected]>
|
PTAL @at15 @AlexaraWu |
gaocegege
commented
Jan 8, 2018
|
|
||
| **日志信息**: | ||
|
|
||
| <!-- 请在 https://pastebin.ubuntu.com/ 中的 Content 处粘贴上 `thesis.log` 内全部内容, 并将生成的链接附在此处, 如 https://pastebin.ubuntu.com/26345571/ --> |
There was a problem hiding this comment.
这样的设定是为了防止 log 太长导致 issue 看起来很费力..
at15
approved these changes
Jan 8, 2018
|
@at15 我觉得提 PR 已经值得鼓励了, 就别用模板为难别人了吧 |
|
英文模板可以再开 issue 去 track 吧, 我对有没有外国友人提 issue 持怀疑态度 |
AlexaraWu
approved these changes
Jan 8, 2018
|
嗯, 不过一个新手用户很难判断哪些信息是必要的 |
|
我又想了一下，为什么不把这个 Issue 模版放在 Wiki 里呢？然后在 |
|
这是 github 的 feature: https://help.github.com/articles/creating-an-issue-template-for-your-repository/ 会在每次创建新 issue 时默认出现在内容框里 |
|
哦哦，是我孤陋寡闻了。:joy: |
|
学到了学到了 |
|
@gaocegege 这个模版文件只有在默认分支里才有效吧？要不要把 dev 设置成默认分支？master 仅做发布使用？ |
|
这不好吧, 等我们发了新版本, 到了 master 分支就好了. 对于发布我的建议是利用 GitHub Release 功能来发布, 开发就在 master 分支去做, 删掉 dev 分支 #237 这里是我的一些看法. 如果 master 只做发布那就跟用 GitHub Release 功能差不多了 |
|
👌 SGTM |
This was referenced Jan 9, 2018
gaocegege
added a commit
that referenced
this pull request
Jan 9, 2018
Signed-off-by: Ce Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #232
Signed-off-by: Ce Gao [email protected]