Add metaport pacakge, remove ima-js, skale-contracts integration & refactoring #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…in portal - update usage
…lorer module, remove duplicated methods
dmytrotkk
changed the title
This was
linked to
issues
Feb 17, 2025
DmytroNazarenko
requested changes
Feb 19, 2025
src/core/constants.ts
Outdated
| export const PORTAL_URLS: Record<string, string> = { | ||
| mainnet: 'https://portal.skale.space/', | ||
| staging: 'https://testnet.portal.skale.space/' | ||
| } | ||
|
|
||
| export { FAQ, MAINNET_CHAIN_LOGOS, VALIDATOR_LOGOS, CONTRACTS_META } | ||
| export { FAQ, MAINNET_CHAIN_LOGOS, VALIDATOR_LOGOS } | ||
|
|
||
| export const DISCORD_INVITE_URL = 'https://discord.com/invite/gM5XBy6' |
There was a problem hiding this comment.
Do we use it anywhere?
DmytroNazarenko
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Custom address on Validator page brokes the page:
https://portal-43d466ad9-skale-network.vercel.app/validator?_customAddress=0xcad41a740cac31aedd1ce40f1cc4824f4bdd283a
There was a problem hiding this comment.
Staking page doesn't work in preview:
https://portal-43d466ad9-skale-network.vercel.app/staking
@DmytroNazarenko Validator and Staking pages fixed in #463 |
DmytroNazarenko
approved these changes
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
skale-contractlibrary integratedima-jspackage dependency dropped