Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schain firewall config during cleaner stage #1140

Merged
merged 11 commits into from
Jan 23, 2025

Fix tests

4e6fd90
Select commit
Loading
Failed to load commit list.
Merged

Remove schain firewall config during cleaner stage #1140

Fix tests
4e6fd90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 22, 2025 in 0s

81.41% (-0.21%) compared to 59235f8

View this Pull Request on Codecov

81.41% (-0.21%) compared to 59235f8

Details

Codecov Report

Attention: Patch coverage is 51.80723% with 40 lines in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (59235f8) to head (4e6fd90).

Files with missing lines Patch % Lines
core/schains/firewall/nftables.py 23.33% 23 Missing ⚠️
core/schains/firewall/firewall_manager.py 33.33% 8 Missing ⚠️
core/schains/firewall/rule_controller.py 64.70% 6 Missing ⚠️
core/schains/firewall/utils.py 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
- Coverage    81.61%   81.41%   -0.21%     
===========================================
  Files          103      103              
  Lines         6517     6570      +53     
===========================================
+ Hits          5319     5349      +30     
- Misses        1198     1221      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov