Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/1755 Improve Logging 2 #2095

Open
wants to merge 20 commits into
base: v4.0.0
Choose a base branch
from

Conversation

PropzSaladaz
Copy link

Description

  • Removed colorful logs from all files using them - cc::warn(), cc::successful(), etc
  • Updated use of loggers to prioritize the usage of LOG( m_typeLogger )
  • Removed std::endl from end of console logs

Tests

No logic was changed - Only tested the project for compilation.

Fixes #1755

Note

This is a replicate from a closed pr that had unsigned commits: #2076
All commits prior to a11a28c remain the same (already reviewed by @olehnikolaiev)

@PropzSaladaz PropzSaladaz added the enhancement New feature or request label Feb 5, 2025
@PropzSaladaz PropzSaladaz self-assigned this Feb 5, 2025
@PropzSaladaz PropzSaladaz linked an issue Feb 5, 2025 that may be closed by this pull request
4 tasks
@PropzSaladaz PropzSaladaz removed the enhancement New feature or request label Feb 6, 2025
@DmytroNazarenko DmytroNazarenko added this to the SKALE 4.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging according code guidelines
3 participants