Added Feature: dogbone fillets on ajoining surfaces #18
Conversation
|
Hi @voglster thanks for the PR I test it tomorrow. |
|
No problem, its my first ever PR.. still learning how to do it right. |
|
Sorry but your PR break some things : With With For comparison here is what it should look like : |
|
Hmmm I must have missed something merging every thing into 1 commit. I
will figure it out and update the pr.
…On Dec 8, 2016 2:14 AM, "Sébastien Mischler (aka skarab)" < ***@***.***> wrote:
Sorry but your PR break some things :
With dogbone = false : It lacks the tabs on the triangles (red arrows)
and adds to the Z frame where it should not (yellow arrows).
[image: dogbone_false]
<https://cloud.githubusercontent.com/assets/796149/21002462/3ffb7e8e-bd26-11e6-9705-5975b227d871.png>
With dogbone = true : Same as false plus all pockets and holes disappear
on the Z frame and on the Y carriage. [image: dogbone_true]
<https://cloud.githubusercontent.com/assets/796149/21002512/8ab99244-bd26-11e6-97a2-7a209de8fa13.png>
For comparison here is what it should look like :
[image: original]
<https://cloud.githubusercontent.com/assets/796149/21002543/ade9ac04-bd26-11e6-8eb2-7baae1be93c3.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAl2ra7rV43sntu4U2O2d5yT-vK-Oe_qks5rF7xlgaJpZM4LEcN2>
.
|
|
I have fixed my error please review at your leisure. Dogbone = True: |
|
It's better, but there are still some mistakes. |
|
hmmm i see the missing ajoining surface... not sure how i missed that. ill
look into the pocket holes as well.
…On Fri, Dec 9, 2016 at 2:17 AM, Sébastien Mischler (aka skarab) < ***@***.***> wrote:
It's better, but there are still some mistakes.
dogbone = false -> All good.
dogbone = true -> It lacks two locations to be consistent (red arrows).
And it still lacks the pockets and holes in the Y carriage (red square).
[image: dogbone_true2]
<https://cloud.githubusercontent.com/assets/796149/21042179/31f9d810-bdf0-11e6-8ffc-c6c4891e8ecb.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAl2rZZXLxeP3UR5GJoJzxWYmPxnpZexks5rGQ6egaJpZM4LEcN2>
.
|
|
hey just letting you know I will be working on this.. just holidays got in the way |
2 New variables in the config:
cutter_size = 3.175 (this is the radius of the cutter)
dogbone = false (if we should render the dogbone fillets or not)
I tried my best to follow your formatting so it just flows. Squashed my commits into just 1 as well. Supercedes PR #17.