Feature/publish to sketchfab #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurL
force-pushed
the
feature/publish-to-sketchfab
branch
from
c74aa70 to
25bd164
Compare
AurL
force-pushed
the
feature/publish-to-sketchfab
branch
from
25bd164 to
1399096
Compare
| if ( lastSplitBackslash > lastSplit ) | ||
| lastSplit = lastSplitBackslash; | ||
| if ( lastSplitSlash > lastSplit ) | ||
| lastSplit = lastSplitSlash; |
There was a problem hiding this comment.
overall indentation
also what happens if worldPath contains neither \ nor /?
There was a problem hiding this comment.
It should be ok since lastSplit is initialized with worldPath ?
There was a problem hiding this comment.
So you're relying on the fact that NULL is 0? I don't like it very much. Also, does it make sense to search for both / and \? Aren't you just looking for the basename?
AurL
force-pushed
the
feature/publish-to-sketchfab
branch
2 times, most recently
from
2ad4c28 to
37ef112
Compare
AurL
force-pushed
the
feature/publish-to-sketchfab
branch
from
89be329 to
bba57d5
Compare
AurL
force-pushed
the
feature/publish-to-sketchfab
branch
4 times, most recently
from
7ed25e7 to
54c5946
Compare
AurL
force-pushed
the
feature/publish-to-sketchfab
branch
3 times, most recently
from
4b878f7 to
9be40d2
Compare
AurL
force-pushed
the
feature/publish-to-sketchfab
branch
from
9be40d2 to
e09ccd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.