Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak deployment workflows #88

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Conversation

hectorsector
Copy link
Contributor

Summary

This PR fixes the course, although we will continue to see deprecation warnings from using the --sdk-auth flag. I'm not finding much evidence that support for this flag will actually be removed any time soon. See Azure/azure-cli#20743 and Azure/azure-cli#19949 (comment) for more information, but the tldr is that flag gives us what we need for this course and there's consensus that, although maybe eventually deprecated, this flag outputs the proper credentials which is preferable to the alternatives. The alternatives include breaking context to create some credentials in the Azure Portal or doing recommended OIDC auth but that requires breaking context even further.

There's a good argument to be made that this course can and probably should be rewritten and slimmed down significantly, but this PR gets it to a working state so users aren't struggling to follow a patchwork of documentation.

Changes

  • Revert Removed deprecated flag --sdk-auth #78
  • Updates instructions so that the user gives their CR_PAT write:packages permissions, required to update or publish a package.
  • Updates user-created workflows to utilize CR_PAT, which wasn't used at all.
  • Fix indentation and step numbering for most steps.

Closes: #84

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@hectorsector hectorsector requested a review from heiskr July 9, 2024 17:14
@heiskr
Copy link
Contributor

heiskr commented Jul 9, 2024

I'll take a look later this week.

Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some good clarifying :) TBH I haven't run the course with these changes and I'm not totally convinced this course is a good fit for Skills in general; but given the volume of feedback on it I think it makes sense to improve it where we can.

.github/steps/2-setup-azure-environment.md Outdated Show resolved Hide resolved
@hectorsector hectorsector merged commit bc19256 into main Jul 10, 2024
2 checks passed
@hectorsector hectorsector deleted the hectorsector/revert-and-fix-auth branch July 10, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] AZURE_CREDENTIALS are in instructions but never created
2 participants