fix: update wallet filtering logic and clean up unused variables in S…

…wapExecutionPage
skip-mev · Dec 26, 2024 · ac9eed7 · ac9eed7
1 parent 0a70f47
commit ac9eed7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/widget/src/components/RenderWalletList.tsx b/packages/widget/src/components/RenderWalletList.tsx
@@ -63,7 +63,7 @@ export const RenderWalletList = ({
 
   const displayWallets = useMemo(() => {
     const filteredWallets = walletList.filter(
-      (wallet) => isMinimalWallet(wallet) && wallet?.isAvailable !== false
+      (wallet) => isManualWalletEntry(wallet) || wallet?.isAvailable !== false
     );
 
     return filteredWallets.length === 1 ? walletList : filteredWallets;
@@ -124,15 +124,15 @@ export const RenderWalletList = ({
 
       const renderedRightContent = rightContent?.() ?? <></>;
 
-      const imageElement = (
+      const imageElement = imageUrl ? (
         <img
           height={35}
           width={35}
           style={{ objectFit: "cover" }}
           src={imageUrl}
           alt={`${name}-logo`}
         />
-      )
+      ) : null;
 
       const onClickConnectWallet = () => {
         if (isMinimalWallet(wallet)) {

diff --git a/packages/widget/src/pages/SwapExecutionPage/SwapExecutionPage.tsx b/packages/widget/src/pages/SwapExecutionPage/SwapExecutionPage.tsx
@@ -98,16 +98,14 @@ export const SwapExecutionPage = () => {
   }, [signaturesRemaining, shouldDisplaySignaturesRemaining]);
 
   const onClickEditDestinationWallet = useMemo(() => {
-    const lastIndex = chainAddresses ? Object.keys(chainAddresses).length - 1 : 0;
-    const destinationAddress = chainAddresses?.[lastIndex]?.address;
     const loadingStates = [
       SwapExecutionState.pending,
       SwapExecutionState.waitingForSigning,
       SwapExecutionState.validatingGasBalance,
       SwapExecutionState.confirmed
     ];
 
-    if (loadingStates.includes(swapExecutionState) || !destinationAddress) {
+    if (loadingStates.includes(swapExecutionState)) {
       return undefined;
     }
 
@@ -116,7 +114,7 @@ export const SwapExecutionPage = () => {
         chainId: route?.destAssetChainID,
       });
     };
-  }, [chainAddresses, swapExecutionState, route?.destAssetChainID]);
+  }, [swapExecutionState, route?.destAssetChainID]);