Add sentry #589
Add sentry #589
Conversation
🦋 Changeset detectedLatest commit: 85585ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
toddkao
force-pushed
the
sentry-integration
branch
from
5f29aef to
37ab8fe
Compare
toddkao
requested review from
codingki,
NotJeremyLiu and
ericHgorski
as code owners
| @@ -96,6 +97,7 @@ export const setSwapExecutionStateAtom = atom(null, (get, set) => { | |||
| } | |||
| }, | |||
| onTransactionBroadcast: async (txInfo) => { | |||
| setUser({ id: txInfo?.txHash }); | |||
There was a problem hiding this comment.
do we need this in addition to the other setUser with the source account address?
There was a problem hiding this comment.
yeah, we should keep both, one is setting id and one is setting username so both will be kept that way we have multiple ways of identifying the replay/session
| @@ -304,6 +305,7 @@ export const SwapPage = () => { | |||
| } | |||
| setChainAddresses({}); | |||
| setCurrentPage(Routes.SwapExecutionPage); | |||
| setUser({ username: sourceAccount?.address }); | |||
There was a problem hiding this comment.
@ericHgorski we have two calls to setUser, the one to set address is here
There was a problem hiding this comment.
we should keep both, that way we have multiple ways of finding the replay
| @@ -304,6 +305,7 @@ export const SwapPage = () => { | |||
| } | |||
| setChainAddresses({}); | |||
| setCurrentPage(Routes.SwapExecutionPage); | |||
| setUser({ username: sourceAccount?.address }); | |||
| setSwapExecutionState(); | |||
There was a problem hiding this comment.
lets also capture the route here
There was a problem hiding this comment.
how should i capture the route? as part of the user?
There was a problem hiding this comment.
not blocking the merge, we can use this https://docs.sentry.io/platforms/javascript/enriching-events/context/
There was a problem hiding this comment.
hmm, ok I'll test tags and contexts in a separate PR to decide which one to use
https://docs.sentry.io/platforms/javascript/enriching-events/tags/
https://docs.sentry.io/platforms/javascript/enriching-events/context/
Add sentry integration
Add session replay, auto recording when error occurs
Add messages for wallet connected/wallet disconnected