[FRE-1314] fix: filter available wallets in RenderWalletList component #597
Conversation
🦋 Changeset detectedLatest commit: 407be91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ericHgorski
changed the title
ericHgorski
requested review from
codingki,
NotJeremyLiu and
toddkao
as code owners
|
Not working for solana wallets |
|
also found some unnecessary hook deps |
This is as intended if only one wallet option is available then we show all available options. I could refine the code so this is only the case with walletconnect and not any length === 1 available wallet list. Its a design question if we're ok with this modal having just a single option. |
|
Ok nice, lgtm if the hook deps fixed |
| /> | ||
| ); | ||
| }, | ||
| [connectMutation] | ||
| ); | ||
|
|
||
| const height = useMemo(() => { | ||
| return Math.min(530, walletList.length * (ITEM_HEIGHT + ITEM_GAP)); | ||
| return Math.min(530, displayWallets.length * (ITEM_HEIGHT + ITEM_GAP)); | ||
| }, [walletList]); |
There was a problem hiding this comment.
| }, [walletList]); | |
| }, [displayWallets]); |
…de displayWallets length
No description provided.