Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with loading all-zero sparse matrices, as the data and ir… #57

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

SebastiaanBreedveld
Copy link
Contributor

… pointers are not stored in the .mat file.

… pointers are not stored in the .mat file.
@skjerns
Copy link
Owner

skjerns commented Jul 17, 2024

perfect!

bonus: could you provide a sample file for this case and write a test in https://github.com/skjerns/mat7.3/blob/master/tests/test_mat73.py ?

alternatively, you can just send me a sample file or some script to create a sample file in MATLAB and I can add that later.

@SebastiaanBreedveld
Copy link
Contributor Author

Sorry, I understand the importance of unit tests, but this is time-wise beyond my reach for now. I also have not used this package directly but this issue caused a problem with another script.

It should be reproducible by using the following Matlab code:
A = sparse([0 0 0; 0 0 0]);
save -v7.3 testSparse.mat A

@skjerns
Copy link
Owner

skjerns commented Jul 18, 2024

sure, no worries! the MATLAB code is enough for me to implement it :)

@skjerns skjerns merged commit ac31ea7 into skjerns:master Jul 18, 2024
14 checks passed
@skjerns
Copy link
Owner

skjerns commented Jul 18, 2024

thanks @SebastiaanBreedveld !

I've added unittests in #58

valp124 pushed a commit to valp124/mat7.3 that referenced this pull request Jul 22, 2024
… pointers are not stored in the .mat file. (skjerns#57)

Co-authored-by: S. Breedveld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants