Remove not needed resource classes + correct readiness check #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most of the
*Resource
classes, that are not really useful in terms of the ResourceManager - these classes are useful in case that we have some CustomResources, for which theisReady()
method is not implemented.Or in this case for
Job
, where we want to have active number of jobs (Pods) > 0.Also, because we were hitting following:
I added check for the kind of the resources, that are not inside of the
resourceTypes
(this follows the logic fabric8 has in their own protected/private methods).