Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed resource classes + correct readiness check #78

Closed
wants to merge 2 commits into from

Conversation

im-konge
Copy link
Member

This PR removes most of the *Resource classes, that are not really useful in terms of the ResourceManager - these classes are useful in case that we have some CustomResources, for which the isReady() method is not implemented.
Or in this case for Job, where we want to have active number of jobs (Pods) > 0.

Also, because we were hitting following:

2024-05-16 13:29:41 [main] INFO  [Wait:65] Waiting for: Resource condition: ready to be fulfilled for resource ServiceAccount/strimzi-access-operator
2024-05-16 13:29:41 [main] WARN  [Readiness:125] ServiceAccount is not a Readiable resource. It needs to be one of [Node, Deployment, ReplicaSet, StatefulSet, Pod, ReplicationController]

I added check for the kind of the resources, that are not inside of the resourceTypes (this follows the logic fabric8 has in their own protected/private methods).

@github-actions github-actions bot requested review from Frawless and kornys May 16, 2024 14:49
@im-konge im-konge closed this May 16, 2024
@kornys kornys deleted the remove-not-needed-resources branch July 3, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant