Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186 umlaute #268

Merged
merged 5 commits into from
Aug 17, 2023
Merged

186 umlaute #268

merged 5 commits into from
Aug 17, 2023

Conversation

sroertgen
Copy link
Contributor

With the update of flexsearch we can now handles search for umlaute properly, e.g.

Screenshot_20230817_150901

Screenshot_20230817_150908

The update caused errors in Jest, which can't handle ES6 stuff well at the moment.
That was also the reason why we couldn't update jsonld (from v5 to v8).
I therefore decided to switch to vitest which just works.

Also updated some other packages.

updating flexsearch caused problems with jest till it still is not able to handle es6 very well.
Hopefully vitest will make future testing much easier.
since we got rid of jest, we can now also finally update jsonld
@sroertgen sroertgen linked an issue Aug 17, 2023 that may be closed by this pull request
@sroertgen sroertgen self-assigned this Aug 17, 2023
@sroertgen
Copy link
Contributor Author

Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sroertgen sroertgen merged commit da37696 into main Aug 17, 2023
3 checks passed
@sroertgen sroertgen deleted the 186-umlaute branch August 17, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umlauts are not indexed properly
2 participants