Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "inbox" and "followers" to JSON-LD context #88

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

acka47
Copy link
Member

@acka47 acka47 commented Jun 18, 2020

Fixes #87

@acka47
Copy link
Member Author

acka47 commented Jun 19, 2020

I think there is something wring with the test infrastructure. All tests fail to run with this message:

Test suite failed to run

[BABEL] /home/runner/work/skohub-vocabs/skohub-vocabs/test/{test}.test.js: Cannot find module '@babel/compat-data/corejs3-shipped-proposals'

Please help, @literarymachine .

@dr0i
Copy link
Member

dr0i commented Jun 19, 2020

I think we can fix it leaving @literarymachine in parental leave ...
To begin with, it npm test works on our machines even using your branch (one must stop the skohub-vocabs daemon, though, for the test instance uses the same port when testing webHookServer. TODO: document this).
Second, e.g. laravel needs a newer babel/preset-env lib ,which may be installed on the github test environment. We use <v7.9.

@dr0i dr0i removed the request for review from literarymachine June 22, 2020 15:02
@dr0i
Copy link
Member

dr0i commented Jun 22, 2020

@acka47 as the last commit fixed the github test - ping if this PR ready to be merged and deployed.

@acka47 acka47 assigned dr0i and unassigned acka47 Jun 23, 2020
@acka47
Copy link
Member Author

acka47 commented Jun 23, 2020

+1 Please merge and deploy

@dr0i dr0i merged commit 52dbabb into master Jun 23, 2020
@dr0i dr0i deleted the 87-addProperties2Context branch June 23, 2020 11:18
@dr0i
Copy link
Member

dr0i commented Jun 23, 2020

Merged and deployed, but see #87 for further questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"followers" and "inbox" keys are not in JSON-LD context
2 participants