Support OIDC providers that return 'iss' in authorization response #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Nabholz <[email protected]>
bnabholz
force-pushed
the
fixes/issue-441
branch
from
bf2a272 to
bfd1625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the authorization provider returns an
issfield in the authorization response, it should be passed into the POST to/oidcand then into theopenid-clientcallback. Fixes issue #441.If
issis not in the authorization response, it still is sent to the/oidcendpoint but with its value null. If this should be filtered out of the payload on the client side, I will revise the commit.