refactor: unify merge_bin scripts #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdb3
force-pushed
the
unify_merge_bin
branch
3 times, most recently
from
e453f87 to
39a2220
Compare
Combines the functionality of merge_bin_update.sh and merge_bin_with_config.sh into merge_bin.sh. Also adds more verbose usage printing.
|
this LGTM. thanks for the tooling help! |
tommywatson
pushed a commit
to tommywatson/ESP-Miner
that referenced
this pull request
Jun 20, 2024
Combines the functionality of merge_bin_update.sh and merge_bin_with_config.sh into merge_bin.sh. Also adds more verbose usage printing.
skot
added a commit
that referenced
this pull request
Jun 20, 2024
* Fixed fan speed web update #141 These changes fix fan rpm/percent requested and update both on the web * fix readme * refactor self_test to be modular for new hardware * Supra 402 (#221) * port TCH Supra 402 branch * refactor TMP1075 (unused?) driver using i2c_master module * pulled in @BitMaker-hub stratum_task.c DNS changes from PR #185 * removing serial debug --------- Co-authored-by: Skot <[email protected]> * adjust share accpeted/rejected functions to take higher level GLOBAL_STATE to fix share accounting. * Code clean resulting from looking into #218 (#220) * Code clean resulting from looking into #218 * Fixed asic count Set canary value for invalid device's asic_count --------- Co-authored-by: tommy <[email protected]> * fix another pointer error * Changes efficiency metric display in AxeOS (#231) Fixes #230 * try to explain nonce space duration from paramters (#228) * try to explain nonce space duration from paramters * Fix Nonce Space duration for BM1397 (no version-rolling) * fixed issue with version mask on 1397. added easy serial debugging on 1397 * cleanup jobID debugs --------- Co-authored-by: Skot <[email protected]> * Update bm1397.c to increase the max frequency to 650Mhz (#209) * Update bm1397.c to increase the max frequency to 650Mhz The original version was setting everything above 500Mhz to 500Mhz, the update increases the limit to 650Mhz. No changes to the web interface - drop-down still shows up to 575Mhz * Update edit.component.ts to include higher freqeuncy for BM1397 * Updated BM1397 frequencies to above 500Mhz * Update bm1397.c * Update bm1397.c * UN-Update readme.md * Update bm1397.c * Update bm1397.c * Update bm1397.c * fix: add recovery page (#232) Adds a recovery web interface to enable users to recover from a failed www.bin update. Partial fix for Issue #213. * refactor: unify merge_bin scripts (#189) Combines the functionality of merge_bin_update.sh and merge_bin_with_config.sh into merge_bin.sh. Also adds more verbose usage printing. * fix: check www.bin size before updating (#216) Adds a basic sanity check for www.bin uploading. Returns 400 if upload is attempted on a file larger than the available partition space. --------- Co-authored-by: tommy <[email protected]> Co-authored-by: Georges Palauqui <[email protected]> Co-authored-by: Skot <[email protected]> Co-authored-by: Nathan Day <[email protected]> Co-authored-by: yanir99 <[email protected]> Co-authored-by: tdb3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that there was a bit of duplication in the merge_bin scripts. This PR combines the functionality of merge_bin_update.sh and merge_bin_with_config.sh into merge_bin.sh.
Now running
merge_bin.sh -u <output_file>is the same as runningmerge_bin_update.sh <output_file>previously.Running
merge_bin.sh -c <output_file>is the same as runningmerge_bin_with_config.sh <output_file>previously.Some considerations/rationale:
merge_bin_update.shandmerge_bin_with_config.share simplified to call merge_bin.sh for now (they can be removed later if desired, kept for deprecation path).merge_bin.sh <output_file>was kept the same to minimize disruption to existing developer workflow. The argument behavior could easily be changed if desired.