Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misc UI Tweaks #368

Merged
merged 12 commits into from
Oct 5, 2024
Merged

fix: Misc UI Tweaks #368

merged 12 commits into from
Oct 5, 2024

Conversation

mrv777
Copy link
Contributor

@mrv777 mrv777 commented Sep 29, 2024

Misc UI Improvements

Changes

  • Added degree symbol (°) to temperature readings
  • Implemented consistent use of hash pipe and capital 'H' for hashrate
  • Added expected efficiency for consistent card displays
  • Reduced menu width for better UI
  • Added average hashrate to chart as a horizontal line
  • Only use 2 decimals < 10, 1 decimal < 100, else 0
  • Format the shares numbers
  • Reduce max data points on chart

@mrv777
Copy link
Contributor Author

mrv777 commented Sep 29, 2024

Okay, so the average hashrate line became a lot of commits. In the end I just made it simply a horizontal line as it looked less cluttered with dots and I think this makes it more clear. Can explore the backend average hashrate, but I think this is a good solution in the mean time

Revert chart delay too as it just feels too slow now.  Keep data points max lower though as 1000 is too crowded, trying 720 instead which is 1 hour of data
@eandersson
Copy link
Collaborator

LGTM only nit comment is that not sure if I prefer Mhz being moved. I assume that was for setups where we run it at 1Ghz or higher?

@mrv777
Copy link
Contributor Author

mrv777 commented Sep 30, 2024

LGTM only nit comment is that not sure if I prefer Mhz being moved. I assume that was for setups where we run it at 1Ghz or higher?

Yeah, once you go over 999mhz it hits the knob around it
Screenshot 2024-09-30 at 8 25 19 AM

If you want instead, we can format the number to Ghz then. It just looked crowded to me, but over 999 is the real problem

@WantClue
Copy link
Collaborator

please add more information to this PR

@mrv777
Copy link
Contributor Author

mrv777 commented Oct 1, 2024

please add more information to this PR

I updated the description, let me know if more is needed

@eandersson eandersson merged commit 1493579 into skot:master Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants