Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If pool not in quicklinks, then don't link #415

Closed
wants to merge 6 commits into from

Conversation

mrv777
Copy link
Contributor

@mrv777 mrv777 commented Oct 17, 2024

If the pool url isn't in the quicklinks, don't link it as we can't be sure of the correct URL to get to the web UI for that pool

Copy link
Collaborator

@eandersson eandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skot
Copy link
Owner

skot commented Nov 4, 2024

It seems like unknown pools are still getting linked for me;
image
in this case the link is to http://192.168.1.234/185.xxx.xxx.51

@eandersson
Copy link
Collaborator

@mrv777 is this PR still valid?

@mrv777
Copy link
Contributor Author

mrv777 commented Nov 7, 2024

I'll close this one as I don't think its valid any more

@mrv777 mrv777 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants