Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api not handling errors properly #424

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix api not handling errors properly #424

merged 3 commits into from
Nov 8, 2024

Conversation

eandersson
Copy link
Collaborator

I found this when implementing the firmware protection that when sending httpd_resp_send_err if you return ESP_FAIL it will trigger a TCP Reset, hiding the actual error message from the user.

WantClue
WantClue approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@WantClue WantClue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Any test responses before merging ?

@WantClue WantClue added enhancement New feature or request accepted This issue will be worked on labels Oct 28, 2024
@eandersson
Copy link
Collaborator Author

LGTM.

Any test responses before merging ?

I think this is fine to merge. Rebased to fix some merge conflicts.

@eandersson eandersson mentioned this pull request Nov 5, 2024
Merged
@WantClue WantClue merged commit 08367a6 into skot:master Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WantClue WantClue WantClue approved these changes

Assignees
No one assigned
Labels
accepted This issue will be worked on enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eandersson @WantClue