replaced default address with a prompt #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr - This PR changes the initial defaults for both fields to something that indicates to the user that they should replace the value with their btc address.
Rationale - I recently updated from a fw version which did not contain the "Fallback" config fields, and was surprised to see an unfamiliar field with a bitcoin address (not mine) prefilled. After investigating what was going on, I realize that this is the same address in the initial default, which of course I changed when initially setting up the unit. However, being an update, I had forgotten about that initial setup, so, the surprise set off alarm bells. It prompted me to make this change to prevent this experience for updaters, while also remaining clear for initial setup.