Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced default address with a prompt #438

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

eyelight
Copy link
Contributor

@eyelight eyelight commented Nov 1, 2024

tldr - This PR changes the initial defaults for both fields to something that indicates to the user that they should replace the value with their btc address.

Rationale - I recently updated from a fw version which did not contain the "Fallback" config fields, and was surprised to see an unfamiliar field with a bitcoin address (not mine) prefilled. After investigating what was going on, I realize that this is the same address in the initial default, which of course I changed when initially setting up the unit. However, being an update, I had forgotten about that initial setup, so, the surprise set off alarm bells. It prompted me to make this change to prevent this experience for updaters, while also remaining clear for initial setup.

@skot
Copy link
Owner

skot commented Nov 1, 2024

This works for me. I think the only time this will come up is for users upgrading from an old version pre-2.3.0. They should already have a primary address configured which will replace these defaults... this means an update won;t stop them from mining.

Defaults for new factory units can still have these defaults set in the config.csv

@skot
Copy link
Owner

skot commented Nov 1, 2024

note: to test this you need to delete the file sdkconfig if present in the project root dir

@skot skot merged commit 8c06f1d into skot:master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants