Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better mobile styles for swarm #458

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Conversation

mrv777
Copy link
Contributor

@mrv777 mrv777 commented Nov 5, 2024

Description

  • Adjusted swarm table styles for better display on mobile
  • Limited temp and power decimals
  • Adjusted layout padding on mobile

@mrv777
Copy link
Contributor Author

mrv777 commented Nov 9, 2024

Also added

  • Total hashrate of all devices in swarm
  • An orange color on temps over 65C to make the danger stand out

Let me know if either aren't wanted, but as a user I would find both useful

@mrv777
Copy link
Contributor Author

mrv777 commented Nov 10, 2024

Added a bit more

  • Disable the refresh button while refreshing
  • Better error handling to prevent an error showing [object Object]
  • Zero out a device that failed to update since the data is no longer valid and makes it stand out more

@mrv777
Copy link
Contributor Author

mrv777 commented Nov 12, 2024

@WantClue Any chance this will make it in 2.3.1? or are we at feature freeze for now and will be next version?

<td>{{axe.power | number: '1.2-2'}} <small>W</small> </td>
<td>{{axe.temp}}°<small>C</small></td>
<td>{{axe.power | number: '1.1-1'}} <small>W</small> </td>
<td [ngClass]="{'text-orange-500': axe.temp > 65}">{{axe.temp | number: '1.0-1'}}°<small>C</small></td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 66 and above feels a bit too aggressive for me, maybe 68 instead?
image

Copy link
Collaborator

@eandersson eandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WantClue
Copy link
Collaborator

Added a bit more

  • Disable the refresh button while refreshing
  • Better error handling to prevent an error showing [object Object]
  • Zero out a device that failed to update since the data is no longer valid and makes it stand out more

Considering it right now. I think this is needed I will test and if it works as expected it gets implemented in 2.3.1

@WantClue WantClue merged commit 93b2e30 into skot:master Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants