Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add restart to settings & better disabled state #493

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

mrv777
Copy link
Contributor

@mrv777 mrv777 commented Nov 18, 2024

Description

@skot
Copy link
Owner

skot commented Nov 21, 2024

The restart button is enabled after I click save, but it doesn't actually restart the Bitaxe when I click on it.
image

@skot
Copy link
Owner

skot commented Nov 21, 2024

I'd like to add this functionality to the network tab too 🙏

@mrv777
Copy link
Contributor Author

mrv777 commented Nov 21, 2024

Sorry about that, simple fix. Should work now. I'll add it to the network tab later too

@mrv777
Copy link
Contributor Author

mrv777 commented Nov 22, 2024

PR updated @skot if you want to test when you get a chance. I tested the settings page, but haven't had a chance yet to upload the changes to a device again to test the network page changes

@skot
Copy link
Owner

skot commented Nov 22, 2024

both settings and network work great! I think this is a huge usability improvement, very nice @mrv777

@skot skot merged commit c745cbb into skot:master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants