add 205 config and remove self test flag #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The units should always test on a factory flash |
|
Please allow discussion for large changes |
|
@eandersson is this going to break how the CI scripts build factory images? |
Yea - we use this for factory, but we could use a different approach for that if needed, but gets tricky if there is an older board that does not support the test flag. |
|
Ok, we definitely don't want to remove selftest support from the esp-miner |
Let me know if you want me to implement it in the CI, instead of reverting this PR. I would need to know though if there are any models that needs to be excluded from the self test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove self test flag as we already have it remove for all other models
add 205 config