Button press cleanup

[skot]

looking at the button handling code after @ACSBEN noticed #506 I found a way to optimize it.

Now it uses interrupt for the button presses, and a timer to determine if it's a long press or not. The regular display update interval is an event group now, and it can be interrupted by a BUTTON_PRESS event.

[mutatrum]

It works, but I have quite a hard time following the code, especially the distinction between short/long press, and the fact there's a timer. I wonder if the code wouldn't be simpler without the event group.

Anyways, a bit of future looking: it is possible to offload button handling and screen transitions to LVGL. See https://docs.lvgl.io/master/details/main-components/indev.html#hardware-button

I can have a stab at that, to see how it looks. I think it would clean up the system task quite a bit, and possible eliminate the system task completely.

[skot]

system.c is getting really big and unwieldy. I think breaking it up into a couple more focused files would help, but that's a "big project".

I'm definitely interested in how this could be done with LVGL.. even if we have to rethink the long press functionality..

[skot]

@mutatrum should we merge this or wait for your LVGL button handling?

[mutatrum]

It's almost done, only the self test is left. Hope to wrap it up tomorrow. It's gonna be real nice 😎

…

On Thu, 28 Nov 2024, 02:00 Skot, ***@***.***> wrote: @mutatrum <https://github.com/mutatrum> should we merge this or wait for your LVGL button handling? — Reply to this email directly, view it on GitHub <#510 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANN34JUMYDUG4XEBOVCI5RD2CZTKBAVCNFSM6AAAAABSKOSUUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGA3DSMBXHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[skot]

It's almost done, only the self test is left. Hope to wrap it up tomorrow. It's gonna be real nice 😎

lots of selftest changes in #524 ...