[WIP] Add parsers #848
[WIP] Add parsers #848
Conversation
Vincent-Maladiere
force-pushed
the
add_parser
branch
from
af4c152
to
01618d7
Compare
|
I'll close this PR and open a new one to help reviewing |
There was a problem hiding this comment.
Thanks for starting this, @Vincent-Maladiere !
could you merge the main branch? now that #819 has been merged it should reduce the diff quite a bit
I'm not sure about the term "parsers/parsing". it doesn't apply to categories nor to non-string input columns, and for numbers and even dates the "parsing" is rather simple. maybe "CategoryConverter", "ToCategory", "ToCategoryTransformer" instead of "CategoryParser"?
| return pd.to_numeric(column, errors=self.errors) | ||
|
|
||
|
|
||
| def _union_category(column, dtype): |
There was a problem hiding this comment.
I think it might be best if transform didn't modify the state of the transformer and if the output type of transform was always the same (rather than different categorical dtypes). maybe an "unknown" category could be systematically added and unseen categories would go in there?
|
closing this as it has been superseded by #902 and other PRs. thanks @Vincent-Maladiere ! |
Introduce _DatetimeParser, _NumericParser, _CategoryParser