Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] concat operation on distributions #499

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SaiRevanth25
Copy link
Contributor

Reference Issues/PRs

#340

What does this implement/fix? Explain your changes.

Implements the concat operation on distributions.

See #340 (comment)

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

@fkiraly fkiraly marked this pull request as draft November 19, 2024 18:28
@fkiraly
Copy link
Collaborator

fkiraly commented Nov 19, 2024

changed it to draft, until it is not finished

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Pattern looks good.

I assume this is work in progress, so some comments:

  • the __init__ may need to have an index and columns argument.
  • implementing mean etc is the old, deprecated extension pattern. Now you need to implement _mean etc, see extension_templates/distributions.
  • there are more methods to implement, and get_test_params should be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants