Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spoteus] Support kinematics-simulator for Spot #129

Open
wants to merge 1 commit into
base: develop/spot
Choose a base branch
from

Conversation

tkmtnt7000
Copy link
Collaborator

@tkmtnt7000 tkmtnt7000 commented Jan 14, 2022

This PR supports kinematics-simulator for Spot.

I fixed the wrong return value of (send self :simulation-modep) because Spot does not use follow_joint_trajectory.
cf: https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/27066da325b7224bb35e3c4ded05b751c96fd907/pr2eus/robot-interface.l#L240-L251

cc:@708yamaguchi

@708yamaguchi
Copy link

Looks good to me.

One thing for more improvement.
From next time, you can separate the commit into functional change and code style change.

For example (https://github.com/sktometometo/jsk_robot/pull/129/files#diff-c70afdbf438eacc1424a31e609ab4e3d94460ba0d89d03df4004fef168731d56L50-R53 ),

(&rest args &key (trajectory-cmd-action-name "/spot/trajectory") (execute-behavior-action-name "/spot_behavior_manager_server/execute_behaviors"))

-> first commit (functional change commit) ->

(&rest args &key (trajectory-cmd-action-name "/spot/trajectory") (execute-behavior-action-name "/spot_behavior_manager_server/execute_behaviors") (simulation-mode nil))

-> second commit (style change commit) ->

   (&rest args
    &key (trajectory-cmd-action-name "/spot/trajectory")
         (execute-behavior-action-name "/spot_behavior_manager_server/execute_behaviors")
         (simulation-mode nil))

@tkmtnt7000
Copy link
Collaborator Author

tkmtnt7000 commented Jan 14, 2022

@708yamaguchi
Thank you for advice.
I'll separate commits of code style change from next time.

@tkmtnt7000
Copy link
Collaborator Author

tkmtnt7000 commented Jan 14, 2022

I forgot to mention that kinematics-simulator is not be displayed until jsk-ros-pkg/jsk_pr2eus#473 is merged.
So, if you want to use kinematics-simulator soon, you have to use jsk-ros-pkg/jsk_pr2eus@256b41e

@tkmtnt7000 tkmtnt7000 changed the title [spoteus] Support kinematic-simulator for Spot [spoteus] Support kinematics-simulator for Spot Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants