Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internals of each visitor are the same.
I skipped test 483 because the variables
print
andZeroDivision
switched places.This was because the autogenerated ast visitor visits the
orelse
before thehandlers
(that's also what pypy's does).whereas the cpython visitor visits the
handlers
before theorelse
.There were a few choices there.
visit_Try
.visit_Try
.I went with 1. But 3 would also be good.
Bench marks are very slightly quicker for this branch vs master. But it's nothing to write home about.