Picture in Picture and background color fix

skyebrowser · Dec 16, 2021 · 01b2bf2 · 01b2bf2
1 parent cda6f68
commit 01b2bf2
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "skye",
-  "version": "6.3.2",
+  "version": "6.4.0",
   "sideEffects": false,
   "description": "Extensible, fast and innovative web browser with Innatical UI.",
   "keywords": [

diff --git a/src/main/menus/view.ts b/src/main/menus/view.ts
@@ -89,6 +89,26 @@ export const getViewMenu = (
     ]);
   }
 
+  if (params.mediaFlags.canShowPictureInPicture) {
+    menuItems = menuItems.concat([
+      {
+        type: 'checkbox',
+        label: 'Picture in Picture',
+        checked: params.mediaFlags.isShowingPictureInPicture,
+        click: () => {
+          webContents.executeJavaScript(
+            params.mediaFlags.isShowingPictureInPicture
+              ? `document.exitPictureInPicture()`
+              : `document.elementFromPoint(${params.x}, ${params.y}).requestPictureInPicture()`,
+          );
+        },
+      },
+      {
+        type: 'separator',
+      },
+    ]);
+  }
+
   if (params.isEditable) {
     menuItems = menuItems.concat([
       {

diff --git a/src/main/view.ts b/src/main/view.ts
@@ -143,6 +143,7 @@ export class View {
       'did-navigate-in-page',
       async (e, url, isMainFrame) => {
         if (isMainFrame) {
+          this.browserView.setBackgroundColor('#FFFFFFFF');
           this.window.updateTitle();
           await this.updateData();
 
@@ -159,19 +160,22 @@ export class View {
     );
 
     this.webContents.addListener('did-stop-loading', async () => {
+      this.browserView.setBackgroundColor('#FFFFFFFF');
       this.updateNavigationState();
       this.emitEvent('loading', false);
       await this.updateURL(this.webContents.getURL());
     });
 
     this.webContents.addListener('did-start-loading', async () => {
+      this.browserView.setBackgroundColor('#FFFFFFFF');
       this.hasError = false;
       this.updateNavigationState();
       this.emitEvent('loading', true);
       await this.updateURL(this.webContents.getURL());
     });
 
     this.webContents.addListener('did-start-navigation', async (e, ...args) => {
+      this.browserView.setBackgroundColor('#FFFFFFFF');
       this.updateNavigationState();
 
       this.favicon = '';