#11 #12 issues fixed #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added last_modified job field @sashabaranov |
|
before |
|
after |
|
|
disneyland/server.go
Outdated
| } | ||
| complexError := retError.ErrorOrNil() | ||
| if complexError != nil { | ||
| return &ListOfJobs{Jobs: r}, detailedInternalError(complexError) |
There was a problem hiding this comment.
This is hard to parse for client, who needs to know which jobs created, and which are not. I suggest modifying rpc return type.
There was a problem hiding this comment.
in which way rpc return type should be modified? how server response should look like?
disneyland/server.go
Outdated
| if err != nil { | ||
| return detailedInternalError(err) | ||
| } | ||
| fmt.Printf("Got %v", req) |
There was a problem hiding this comment.
Please use normal logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.