Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Skylight::Normalizers::Normalizer -> Skylight::Core::Normalizers::Normalizer #120

Open
hmcfletch opened this issue May 15, 2018 · 3 comments
Open

Document Skylight::Normalizers::Normalizer -> Skylight::Core::Normalizers::Normalizer #120

hmcfletch opened this issue May 15, 2018 · 3 comments

Comments

@hmcfletch
Copy link

I'm not sure which release this happened in, but could you put something in the Changelog for this? It will break all third party normalizers.
@hmcfletch hmcfletch mentioned this issue May 15, 2018
Open
@wagenet
Copy link
Contributor

wagenet commented May 15, 2018

@hmcfletch This API has never been publicly documented. That said, it would be worth documenting in the future.

@hmcfletch
Copy link
Author

Agreed. Docs and examples would help a lot for those needing to make their own normalizers or those hooking into AS::Notifications. In the mean time, I think I mention in the Changelog for the right version would be helpful for those who run into this issue.

@wagenet
Copy link
Contributor

wagenet commented May 16, 2018

By the way, Skylight::Core was introduced in 2.0.

@stas stas mentioned this issue Jan 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagenet @hmcfletch