#27 SVG spline interpolation count is proportional to number of contr…

…ol points - improves SVG fidelity for large splines
skymakerolof · Jul 12, 2018 · 6424faf · 6424faf
1 parent 0a67047
commit 6424faf
Show file tree

Hide file tree

Showing 4 changed files with 21,493 additions and 4 deletions.
diff --git a/src/entityToPolyline.js b/src/entityToPolyline.js
@@ -199,8 +199,12 @@ module.exports = function (entity) {
     const order = entity.degree + 1
     const knots = entity.knots
     polyline = []
-    for (let t = 0; t <= 100; t += 1) {
-      const p = bspline(t / 100, order, controlPoints, knots)
+    // In trying to keep the polyline size to a reasonable value,
+    // the number of interpolated points is proportional to the
+    // number of control points
+    const numInterpolations = controlPoints.length * 100
+    for (let t = 0; t <= numInterpolations; t += 1) {
+      const p = bspline(t / numInterpolations, order, controlPoints, knots)
       polyline.push(p)
     }
   }

diff --git a/test/functional/svgentities.test.js b/test/functional/svgentities.test.js
@@ -26,4 +26,5 @@ describe('svg entities', function () {
   createTest('floorplan')
   createTest('Ceco.NET-Architecture-Tm-53')
   createTest('issue21')
+  createTest('issue27')
 })