Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Multiple k8s support #4586
[Docs] Multiple k8s support #4586
Changes from 11 commits
8ca950c
de8a688
55c26c3
92b4ded
161ceff
6a48757
867a239
fe4c8c4
aee21f5
254b393
903a7ee
b6f6c0f
fd097f4
8b53611
03d9122
c6cf614
e70d837
bd6eeb6
e358437
9dd445a
9a906a4
935c086
bb0a981
34d6bbe
2797067
4368e4f
7aac76a
eb5b161
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to have a section on adding contexts to allowed_contexts". If
allowed_contexts
is not set, I believe--region
will not work, we will only use the active context.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to clearly mark section titles:
Step 1 - Set Up Credentials for Multiple Kubernetes Clusters
Step 2 - Configure SkyPilot to access multiple clusters
Then have sections on launching, show-gpus, failover etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the final check, we have the users run
sky check kubernetes
as a way to verify which contexts are available to SkyPilot.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Updated the doc. PTAL.