[Dashboard] Fix Log Download #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cg505
reviewed
Mar 3, 2025
sky/jobs/dashboard/dashboard.py
Outdated
Comment on lines
180
to
191
| # Validate column count | ||
| if rows and len(rows[0]) != len(JOB_TABLE_COLUMNS): | ||
| # Validate column count - Updated to account for the extra log content column | ||
| if rows and len(rows[0]) != len(JOB_TABLE_COLUMNS) + 1: # +1 for log content | ||
| raise RuntimeError( | ||
| f'Dashboard code and managed job queue code are out of sync. ' | ||
| f'Expected {(JOB_TABLE_COLUMNS)} columns, got {(rows[0])}') | ||
| f'Expected {len(JOB_TABLE_COLUMNS)} columns plus log content, got {len(rows[0])} total') |
There was a problem hiding this comment.
Why can't we just add the new column to JOB_TABLE_COLUMNS? Would also make the above logic (all the else: row.append stuff) less error-prone.
cg505
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the previous version that cannot download logs in the dashboard
it also adds a preview page of the controller log