Fix CI emulator tests #1176
Merged
Fix CI emulator tests #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark tests do not work (by default) on emulators. We can suppress the error and get them to run, but there's little benefit. Better to just disable them.
chrisbanes
changed the title
Majority of things now run on ubuntu-latest, and iOS is now a separate job on MacOS
chrisbanes
force-pushed
the
cb/ci-fork-emulator-tests
branch
from
18f77db to
28bbbde
Compare
ZacSweers
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to
macos-14means that we can't use x64 emulator (as currently set). Ideally we would just use ARM64 emulators, but that is blocked by Support for M1 Silicon - HVF error: HV_UNSUPPORTED ReactiveCircus/android-emulator-runner#350 though.Instead I've refactored the CI setup:
ubuntu-latest. We can use the new nested-virt KVM support to make the emulator fast there.macos-14but only for iOS builds in a separate job. This is similar to what I do in Tivi.publishonly happens when all of the other jobs pass.Benchmark tests do not work (by default) on emulators, which is why they've been failing for a while. We can suppress that error and get them to run but there's little benefit, so it's better to just disable them when running on an emulator.