Skip to content

Commit

Permalink
undo changes in v14
Browse files Browse the repository at this point in the history
  • Loading branch information
tanjinx committed Jan 24, 2024
1 parent c01ba54 commit 234d185
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions go/vt/discovery/tablet_health_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ package discovery
import (
"context"
"fmt"
"strings"
"sync"
"time"

Expand Down Expand Up @@ -273,7 +272,7 @@ func (thc *tabletHealthCheck) checkConn(hc *HealthCheckImpl) {
}()

// Read stream health responses.
err := thc.stream(streamCtx, func(shr *query.StreamHealthResponse) error {
thc.stream(streamCtx, func(shr *query.StreamHealthResponse) error {
// We received a message. Reset the back-off.
retryDelay = hc.retryDelay
// Don't block on send to avoid deadlocks.
Expand All @@ -287,7 +286,7 @@ func (thc *tabletHealthCheck) checkConn(hc *HealthCheckImpl) {
// streamCancel to make sure the watcher goroutine terminates.
streamCancel()

if err != nil {
/*if err != nil {
hcErrorCounters.Add([]string{thc.Target.Keyspace, thc.Target.Shard, topoproto.TabletTypeLString(thc.Target.TabletType)}, 1)
// This means that another tablet has taken over the host:port that we were connected to.
// So let's remove the tablet's data from the healthcheck, and if it is still a part of the
Expand All @@ -302,7 +301,8 @@ func (thc *tabletHealthCheck) checkConn(hc *HealthCheckImpl) {
// trivialUpdate = false because this is an error
// up = false because we did not get a healthy response
hc.updateHealth(thc.SimpleCopy(), thc.Target, false, false)
}
}*/

// If there was a timeout send an error. We do this after stream has returned.
// This will ensure that this update prevails over any previous message that
// stream could have sent.
Expand Down

0 comments on commit 234d185

Please sign in to comment.