Skip to content

Commit

Permalink
fix flags
Browse files Browse the repository at this point in the history
Signed-off-by: Esme Lamb <[email protected]>
  • Loading branch information
dedelala committed Nov 12, 2024
1 parent 0ef8172 commit 5673ad0
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions go/cmd/vtgateproxy/vtgateproxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (

func init() {
servenv.RegisterDefaultFlags()
servenv.RegisterGRPCServerFlags()
}

func main() {
Expand Down
1 change: 1 addition & 0 deletions go/vt/grpcclient/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ var (
"vtctld",
"vtgate",
"vtgateclienttest",
"vtgateproxy",
"vtgr",
"vtorc",
"vttablet",
Expand Down
9 changes: 6 additions & 3 deletions go/vt/servenv/servenv.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ func Init() {

// Once you run as root, you pretty much destroy the chances of a
// non-privileged user starting the program correctly.
if uid := os.Getuid(); uid == 0 {
// log.Exitf("servenv.Init: running this as root makes no sense")
}
// if uid := os.Getuid(); uid == 0 {
// log.Exitf("servenv.Init: running this as root makes no sense")
// }

// We used to set this limit directly, but you pretty much have to
// use a root account to allow increasing a limit reliably. Dropping
Expand Down Expand Up @@ -384,6 +384,7 @@ func init() {
"vtctlclient",
"vtctld",
"vtgate",
"vtgateproxy",
"vttablet",
} {
OnParseFor(cmd, trace.RegisterFlags)
Expand All @@ -398,6 +399,7 @@ func init() {
"vtctld",
"vtgate",
"vtgateclienttest",
"vtgateproxy",
"vtgr",
"vttablet",
"vttestserver",
Expand All @@ -411,6 +413,7 @@ func init() {
"vtcombo",
"vtctld",
"vtgate",
"vtgateproxy",
"vtgr",
"vttablet",
"vtorc",
Expand Down
1 change: 1 addition & 0 deletions go/vt/vtgate/grpcvtgateconn/conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ func init() {
"vtcombo",
"vtctl",
"vttestserver",
"vtgateproxy",
} {
servenv.OnParseFor(cmd, registerFlags)
}
Expand Down

0 comments on commit 5673ad0

Please sign in to comment.