slack-vitess-r15.0.5: add slack_cross_cell custom durability poli…

…cy (#266)

* `slack-vitess-r15.0.5`: add `slack_cross_cell` custom durability policy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy again

Signed-off-by: Tim Vaillancourt <[email protected]>

* Use tag

Signed-off-by: Tim Vaillancourt <[email protected]>

* use v0.15.1

Signed-off-by: Tim Vaillancourt <[email protected]>

* update shim

Signed-off-by: Tim Vaillancourt <[email protected]>

* Make `Durabler` interface methods public (vitessio#15548)

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>

* Update `slack_cross_cell` shim

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy again

Signed-off-by: Tim Vaillancourt <[email protected]>

* Allow private go module from vitess-additions repo

Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix typo

Signed-off-by: Tim Vaillancourt <[email protected]>

* Missing non-template update

Signed-off-by: Tim Vaillancourt <[email protected]>

* Missing non-template update

Signed-off-by: Tim Vaillancourt <[email protected]>

* Missing non-template update, pt 3

Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix docker tests

Signed-off-by: Tim Vaillancourt <[email protected]>

* make proto

Signed-off-by: Tim Vaillancourt <[email protected]>

* fix upgrade/downgrade tests

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update all the Go dependencies (vitessio#11741)

* Update all the Go dependencies

This seems to work for the basics just fine, so let's have CI take a run
at this as well to update these.

Only one small update to the Azure blob storage handling seems needed so
far.

Signed-off-by: Dirkjan Bussink <[email protected]>

* Use correct proto comparisons

We're using `reflect.DeepEqual` or `testify` helpers that essentially
use that in a number of places are comparing protobufs. This is not
supported though, protobufs are not comparable with `reflect.DeepEqual`.

This is exposed because of the tiny patch bump of protobuf which changes
some internal optimization of how it initializes protobufs that breaks
all this.

Instead, move to the appropriate helpers here.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

* Resolve signature mismatch

Signed-off-by: Tim Vaillancourt <[email protected]>

* revert protobuf version

Signed-off-by: Tim Vaillancourt <[email protected]>

* revert protobuf version, pt 2

Signed-off-by: Tim Vaillancourt <[email protected]>

* Revert "Update all the Go dependencies (vitessio#11741)"

This reverts commit 18faa1e.

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>

.github/workflows/check_make_vtadmin_authz_testgen.yml

@@ -5,6 +5,9 @@ jobs:
   build:
     name: Check Make vtadmin_authz_testgen
     runs-on: ubuntu-latest
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
     steps:
     - name: Check if workflow needs to be skipped
       id: skip-workflow
@@ -40,6 +43,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Tune the OS
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.vtadmin_changes == 'true'
       run: |

.github/workflows/cluster_endtoend_12.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (12)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_13.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (13)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_15.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (15)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_18.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (18)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_21.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (21)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_22.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (22)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_ers_prs_newfeatures_heavy.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (ers_prs_newfeatures_heavy)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_mysql80.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (mysql80)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_mysql_server_vault.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (mysql_server_vault)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_declarative.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_declarative)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_ghost.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_ghost)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_revert.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_revert)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_revertible.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_revertible)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_scheduler.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_scheduler)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_singleton.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_singleton)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_vrepl.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_vrepl)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_vrepl_stress.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_vrepl_stress)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_vrepl_stress_suite.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_vrepl_stress_suite)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4

.github/workflows/cluster_endtoend_onlineddl_vrepl_suite.yml

@@ -11,6 +11,9 @@ jobs:
     name: Run endtoend tests on Cluster (onlineddl_vrepl_suite)
     runs-on:
       group: vitess-ubuntu20
+    env:
+      GOPRIVATE: github.com/slackhq/vitess-addons
+      GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
 
     steps:
     - name: Check if workflow needs to be skipped
@@ -50,6 +53,9 @@ jobs:
       with:
         go-version: 1.21.8
 
+    - name: Setup github.com/slackhq/vitess-additions access token
+      run: git config --global url.https://[email protected]/.insteadOf https://github.com/
+
     - name: Set up python
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true'
       uses: actions/setup-python@v4