return noop span if no vt_span_context

slackhq · Oct 3, 2023 · d0abc8c · d0abc8c
1 parent 6cb6e9b
commit d0abc8c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/go/vt/vtgate/plugin_mysql_server.go b/go/vt/vtgate/plugin_mysql_server.go
@@ -157,6 +157,9 @@ func startSpanTestable(ctx context.Context, query, label string,
 	_, comments := sqlparser.SplitMarginComments(query)
 	match := r.FindStringSubmatch(comments.Leading)
 	span, ctx := getSpan(ctx, match, newSpan, label, newSpanFromString)
+	if len(match) == 0 {
+		return trace.NoopSpan{}, ctx, nil
+	}
 
 	trace.AnnotateSQL(span, sqlparser.Preview(query))
 
@@ -169,6 +172,7 @@ func getSpan(ctx context.Context, match []string, newSpan func(context.Context,
 		var err error
 		span, ctx, err = newSpanFromString(ctx, match[1], label)
 		if err == nil {
+			span.Annotate("vt_span_context", match[0])
 			return span, ctx
 		}
 		log.Warningf("Unable to parse VT_SPAN_CONTEXT: %s", err.Error())