Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update our v14 build with the latest Go 1.20 #147

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Update our v14 build with the latest Go 1.20 #147

merged 14 commits into from
Nov 30, 2023

Conversation

maksimov
Copy link
Collaborator

@maksimov maksimov commented Nov 1, 2023 •
edited
Loading

Description

Want to try a few things here:

  • Build with the latest version of Go 1.20
  • Make absolute minimum changes, e.g. according to upstream we don't need to change the bootstrap image version at all!

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

maksimov and others added 14 commits November 1, 2023 22:23
@maksimov
upgrade bootstrap to 1.20
929dbe9
@maksimov
update workflow
e58ebef
@maksimov
Merge branch 'slack-vitess-r14.0.5' into tiny-upgrade-go-1.20.latest
4c77fcd
@maksimov
necessary go changes + two more tests
a5ae0c5
@maksimov
Merge branch 'tiny-upgrade-go-1.20.latest' of github.com:slackhq/vite…
a1a0432 
…ss into tiny-upgrade-go-1.20.latest
@maksimov
update two more tests to match Go 1.20
49b42dd
@maksimov
update remaining tests to use Go 1.20+
0d7b9ba
@maksimov
enable logging in the failing tests
e0232e9
@maksimov
revert bootstrap version back to 10.2
5f2d2ce
@maksimov
want to test if the 1.20 really breaks this test
9dc8ae0
@maksimov
Merge branch 'slack-vitess-r14.0.5' into tiny-upgrade-go-1.20.latest
1e31919
@maksimov
fixing merge typo
f61c4c6
@maksimov
Revert "want to test if the 1.20 really breaks this test"
e6b8aff 
This reverts commit 9dc8ae0.
@maksimov
Revert "enable logging in the failing tests"
4251bf8 
This reverts commit e0232e9.
@maksimov maksimov changed the title upgrade bootstrap to 1.20 Update our v14 build with the latest Go 1.20 Nov 30, 2023
@maksimov maksimov marked this pull request as ready for review November 30, 2023 13:07
@maksimov maksimov requested a review from a team as a code owner November 30, 2023 13:07
ejortegau
ejortegau approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@ejortegau ejortegau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maksimov maksimov merged commit 590d17e into slack-vitess-r14.0.5 Nov 30, 2023
241 checks passed
@maksimov maksimov deleted the tiny-upgrade-go-1.20.latest branch November 30, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejortegau ejortegau ejortegau approved these changes

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksimov @ejortegau