Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r15.0.5: backport vitessio/vitess#14428 from v16 #166

Merged
merged 3 commits into from
Nov 13, 2023
Merged

slack-vitess-r15.0.5: backport vitessio/vitess#14428 from v16 #166

merged 3 commits into from
Nov 13, 2023

Conversation

timvaillancourt
Copy link
Member

Description

This PR backports the upstream PR vitessio#14426 using the v16 backport of this change, as that is the closest release to v15

Related Issue(s)

  1. Make column resolution closer to MySQL vitessio/vitess#14426 (original PR)
  2. [release-16.0] Make column resolution closer to MySQL (#14426) vitessio/vitess#14428 (v16 backport)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented Nov 9, 2023

Thanks for the contribution! Before we can merge this, we need @systay to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone Nov 9, 2023
@timvaillancourt timvaillancourt marked this pull request as ready for review November 9, 2023 23:28
@timvaillancourt timvaillancourt requested a review from a team as a code owner November 9, 2023 23:28
tanjinx
tanjinx approved these changes Nov 13, 2023
View reviewed changes
Copy link

@tanjinx tanjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just compared side by side.

@timvaillancourt timvaillancourt merged commit 517fad7 into slack-vitess-r15.0.5 Nov 13, 2023
228 of 229 checks passed
@timvaillancourt timvaillancourt deleted the pr-14426-slack-vitess-r15.0.5 branch November 13, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
cla:missing query-planner upstream-backport An upstream backport v15 v16-backport
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @tanjinx @systay