Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack vitess r14.0.5 dsdefense throttle only if lag 2 #172

Merged
merged 15 commits into from
Feb 13, 2024
Merged

Slack vitess r14.0.5 dsdefense throttle only if lag 2 #172

merged 15 commits into from
Feb 13, 2024

Conversation

ejortegau
Copy link
Collaborator

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@ejortegau
TxThrottler only throttles if current lag is above threshold.
714ae9d 
This the lag caches in MaxReplicationLagModule

Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Fix tests
51daff1 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Make linter happy
414b0ec 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Make linter happy
ac47e7f 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau ejortegau marked this pull request as ready for review December 20, 2023 12:59
@ejortegau ejortegau requested a review from a team as a code owner December 20, 2023 12:59
@ejortegau
Eduardo.ortega/slack vitess r14.0.5 fix mysql pkgs (#174)
36088df 
* Fix MySQL repo & key

Signed-off-by: Eduardo J. Ortega U <[email protected]>

* More fix MySQL repo & key

Signed-off-by: Eduardo J. Ortega U <[email protected]>

---------

Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Merge branch 'slack-vitess-r14.0.5-dsdefense' into slack-vitess-r14.0…
eedbfff 
….5-dsdefense-throttle-only-if-lag-2
@ejortegau
Merge branch 'slack-vitess-r14.0.5-dsdefense' into slack-vitess-r14.0…
e53536b 
….5-dsdefense-throttle-only-if-lag-2
@ejortegau
Address PR comments
9dc9ccb 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Fix tests
ee4838a 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Remove useless changes
38fb7b9 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Remove useless changes
01095bc 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Replace aotmic.Int64 with atomic.(Load|Store)Int64 to avoid CI issues
0f40692 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Fix unit tests race
e656e73 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau
Merge branch 'slack-vitess-r14.0.5-dsdefense' into slack-vitess-r14.0…
e994868 
….5-dsdefense-throttle-only-if-lag-2

Signed-off-by: Eduardo J. Ortega U. <[email protected]>
@ejortegau
Address upstream PR comments
7a086fc 
Signed-off-by: Eduardo J. Ortega U <[email protected]>
@ejortegau ejortegau merged commit 534b326 into slack-vitess-r14.0.5-dsdefense Feb 13, 2024
241 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejortegau @timvaillancourt