Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit concurrency of .AddTablet() calls in discovery healthcheck #180

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Jan 18, 2024

Description

This PR limits the number of concurrent .AddTablet(...) calls that can occur at the same time, to avoid hitting go runtime limits

A default of 1024 32 is used with a new flag named --tablet_discovery_concurrency --healthcheck_concurrency to limit this

To explain the go.sum update, CI requested it. I wonder if a previous merge had an inconsistent go mod setup:

go: downloading github.com/jtolds/gls v4.20.0+incompatible
go: downloading github.com/smartystreets/assertions v0.0.0-20190116191733-b6c0e53d7304
go: downloading github.com/gopherjs/gopherjs v0.0.0-20181103185306-d5[47](https://github.com/slackhq/vitess/actions/runs/7571374065/job/20618771953?pr=180#step:15:48)d1d9531e
go: downloading modernc.org/httpfs v1.0.6
go: downloading modernc.org/z v1.7.0
We wish to maintain a tidy state for go mod. Please run `go mod tidy` on your branch, commit and push again.
Running `go mod tidy` on this CI test yields with the following changes:
 M go.sum

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt requested a review from a team as a code owner January 18, 2024 14:07
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt changed the title Limit concurrency of .AddTablet() calls in topology watcher Limit concurrency of .AddTablet() calls in discovery healthcheck Jan 19, 2024
@timvaillancourt
Copy link
Member Author

Closing in favour of #199

@timvaillancourt timvaillancourt deleted the discovery-loadTablets-pool-slack-vitess-r14.0.5 branch January 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant