Limit concurrency of .AddTablet() calls in discovery healthcheck #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR limits the number of concurrent
.AddTablet(...)
calls that can occur at the same time, to avoid hitting go runtime limitsA default of
1024
32
is used with a new flag named--tablet_discovery_concurrency
--healthcheck_concurrency
to limit thisTo explain the
go.sum
update, CI requested it. I wonder if a previous merge had an inconsistent go mod setup:Related Issue(s)
Checklist
Deployment Notes