vtgateproxy: refactor to have a single parser and more efficient shuffle #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we only have a single entity watching the file and dispatching out to the resolvers when things change rather than a bunch of tickers watching the file. Also cleaned up the code a bunch.
jscheinblum
reviewed
Mar 29, 2024
| // "type": "aux" | ||
| // }, | ||
| // | ||
| // Naming scheme: | ||
| // vtgate://<type>?num_connections=<int>&az_id=<string> | ||
| // URKL scheme: |
jscheinblum
approved these changes
Mar 29, 2024
|
This branch rotted a bit and then had a conflict. Rebased and will re-open on a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the discovery logic to have a single watcher for the parsed file, and then each resolver just gets callbacks from there.
Also clean up and consolidate the command line flags.
Also implement a more efficient single pass shuffle scan because it seemed nifty.