slack-19.0
: optimize sqlutils.ToSqlite3Dialect
, part 2
#546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow-up to upstreaming #545, I made a few more improvements to the optimisation. Now read queries bypass several regex filters and benchmark 19% better
See vitessio/vitess#17113 for a full explanation. This is a pre-backport of that PR, on top of the original POC
Before
After (8-9% improvement for writes, 19% reads)
Related Issue(s)
vitessio/vitess#17113
Checklist
Deployment Notes