DEP: Remove References to Deprecated QVariant #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdomke
force-pushed
the
dev_remove_qvariant
branch
from
d6a5ad7 to
84aab75
Compare
|
Looks like most, if not all, references to QVariant were removed in #1139 But I still needed to keep a change to archiver_time_plot_editor.py where an empty string was returned when it should be None. |
jbellister-slac
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AbstractItemModel.dataandAbstractItemModel.setData, returnsNoneinstead of an emptyQVariantobject. This is done because QVariant is not really needed in PyQt like it is in Qt.While this documentation suggests returning an invalid QVariant, it doesn't specify what an invalid QVariant should be
This documentation suggests that
Nonecan be used as an invalidQVariant.