Added DMA configurable timeout register #1246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruck314
reviewed
Mar 18, 2025
|
@ruck314 I think I also need to set 'timeout' register here: https://github.com/slaclab/axi-pcie-core/blob/211890d800e999ea496442d8b279f983c9d89734/protocol/gpuAsync/rtl/AxiPcieGpuAsyncControl.vhd#L302. Do you agree? |
ruck314
reviewed
Mar 18, 2025
ruck314
changed the title
JJL772
requested changes
Mar 24, 2025
Co-authored-by: Jeremy L. <[email protected]>
|
Also getting a build error from missing |
|
The issues should be fixed now. |
ruck314
reviewed
Mar 25, 2025
|
@mmishra9 Let me know when you have completed your building and regression testing with hardware. After you are done with that, then I will approve and merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configurable timeout register to acknowledge the timeout
Description
Added a configurable timeout register which was earlier hardcoded. If timeout reg value is reached before the write transactions are completed, the descriptor is returned.