improve benchmark setup

slashmo · Sep 14, 2024 · 319810a · 319810a
1 parent 02f0088
commit 319810a
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/Benchmarks/OTelTraceIdRatioBasedSamplerBenchmark/OTelTraceIdRatioBasedSamplerBenchmark.swift b/Benchmarks/OTelTraceIdRatioBasedSamplerBenchmark/OTelTraceIdRatioBasedSamplerBenchmark.swift
@@ -2,20 +2,27 @@
 
 import Benchmark
 import OTel
+import W3CTraceContext
 
 let benchmarks = {
     Benchmark("OTelTraceIdRatioBasedSampler") { benchmark in
 
         let sampler = OTelTraceIdRatioBasedSampler(ratio: 0.5)
-        for _ in benchmark.scaledIterations {
+
+        let traceIds = benchmark.scaledIterations.map { _ in TraceID.random() }
+
+        benchmark.startMeasurement()
+
+        for traceId in traceIds {
             _ = sampler.samplingResult(
                 operationName: "some-op",
                 kind: .internal,
-                traceID: .random(),
+                traceID: traceId,
                 attributes: [:],
                 links: [],
                 parentContext: .topLevel)
         }
+
+        benchmark.stopMeasurement()
     }
-    // Add additional benchmarks here
 }